Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add check for name being part of alt_name #2333

Merged
merged 1 commit into from
Sep 14, 2024
Merged

Conversation

Famlam
Copy link
Collaborator

@Famlam Famlam commented Sep 13, 2024

JOSMs validator rules already check if the value of name is equal to alt_name.
This rule instead checks if the value of name is part of alt_name when alt_name contains multiple values

Example: https://www.openstreetmap.org/way/1277853482
name=Paulusbron
alt_name=Paulusbron;Op den born

Requires 2330 and 2332 to be merged first

Note: I have no idea how many cases there will be worldwide. I just spotted this one and thought it could be interesting, but feel free to reject if it's too specific.

JOSMs validator rules already check if the value of name is equal to alt_name. This rule instead checks if the value of name is part of alt_name when alt_name contains multiple values
@Famlam Famlam marked this pull request as ready for review September 14, 2024 14:38
@frodrigo frodrigo merged commit 8bf8f8b into dev Sep 14, 2024
6 checks passed
@Famlam Famlam deleted the famlam-nameinaltname branch September 14, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants