-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul osm2pgsql style #3615
Merged
Merged
Overhaul osm2pgsql style #3615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This already allows to run Nominatim under themepark, currently as a topic-less theme.
Defining a tag as deleteable/extratag and main tag is mutually exclusive and deleting certain key/value combinations to exclude them from being used as a main tag is confusing. By merging the handling, such excludes can now be made explicit in the main list. By using the same lookup table, it is now also possible to have a short-cut for uninteresting objects.
Now implemented as a simple filter function which can also be customized by the user.
Introduces presets which avoid much of the previous configuration duplication. The original import files are now thin wrappers around the themepark themes.
These footways are part of a street that is usually already named.
If an object doesn't have a useable main tag, then the names should always be ignored, independently of the presence of housenumbers. We have to assume that the name belongs to a feature that was intentionally filtered out.
Publicly accessible ones are usually mapped as the bigger area with the water park.
CI failures are due to OSM outage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started out as a simple task to make the Nominatim osm2pgsql import style compatible with osm2pgsql-themepark and ended up to be a complete refresh of the style implementation.
The philosophy of the configuration script stays largely the same but there are some significant changes in the implementation:
delete
andextra
main tag settings, make the exclusion more explicit.The changes are mostly backwards compatible, i.e. your custom styles should still work as before. The only exception is customization of the
process_tags()
function. This function is no longer considered public and neither are the helper functions used in it. They currently still work but will be removed at some point.Finally, the actual goal, running under themepark, is now possible as well. Nominatim will export the appropriate variables to ensure that the theme is found. Using themepark it becomes easy to run Nominatim alongside other projects like openstreetmap-carto in the same database. I will update the cookbook after the next release.
This change also includes some improvements to the style which are now possible because of the new structure:
highway=footway
when they are sidewalks and crossingsinformation=*
for the class/type fortourism=information
objects, when availablewater=*
for the class/type fornatural=water
when available and exclude water areas for rivers, streams and the like where there is already a waterwaylock_name
(closes Support for key "lock_name" #3365)