Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a second 'World Imagery (Clarity)' layer #391

Merged
merged 2 commits into from
Jan 31, 2018

Conversation

jgravois
Copy link
Contributor

@jgravois jgravois commented Jan 30, 2018

Esri World Imagery (Clarity) - two for the price of one!

ref: #358 (comment)

@bhousel
Copy link
Member

bhousel commented Jan 31, 2018

Awesome, thanks @jgravois 🙌

@bhousel bhousel merged commit e6688dd into osmlab:gh-pages Jan 31, 2018
@jgravois jgravois deleted the more-esri-imagery branch January 31, 2018 15:20
@simonpoole
Copy link
Contributor

The imagery files were not regenerated in/after this PR.

@bhousel
Copy link
Member

bhousel commented Feb 1, 2018

@simonpoole I think 9b52fb1 includes the regenerated files?
In any case, I just did a clean build and git tells me nothing changed.

@simonpoole
Copy link
Contributor

Operator error on my behalf, sorry. The underlying issue is that we don't minimize the output of concatenating the sources in the repo, which forces an extra step for no good reason on consumers that need to be data size aware. I minimize with minimize-js (node), would it be acceptable to do that for the output files for the whole repo?

@bhousel
Copy link
Member

bhousel commented Feb 1, 2018

would it be acceptable to do that for the output files for the whole repo?

Sure, seems fine to me..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants