Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit names to a single classification #1

Closed
aaronlidman opened this issue Nov 20, 2013 · 2 comments
Closed

Limit names to a single classification #1

aaronlidman opened this issue Nov 20, 2013 · 2 comments

Comments

@aaronlidman
Copy link
Contributor

I didn't think this would be necessary but initial implementation of Quick Add presets in iD shows it really is. Probably needs to be handled in canonical somehow or we just automatically revert to the most common usage based on count.

So right now we have amenity=restaurant name=McDonald's and amenity=fast_food name=McDonald's. We should only have one, it makes searching by name less useful to have more than one.

@aaronlidman
Copy link
Contributor Author

This isn't that simple. Sometimes we do want multiple hits, sometimes they're legitimate and if the list gets even larger we will have more multiples. Obvious case is 7-Eleven convenience_store and 7-Eleven fuel. The same goes for many grocery chains that also do fuel. But we do want to enforce a singular, most correct, McDonalds classification and for that count is probably good enough.

@aaronlidman
Copy link
Contributor Author

This is mostly resolved: aa17435.

screen shot 2013-11-25 at 4 03 10 pm

Right now nothing is automatic. When running make it will print a large list of names that are associated with more than one category. That list can then be helpful for manually adding nix_value entries to canonical.json, which will then ignore any category matching a nix_value. This is starting to get more complicated, if it required more logic it might be smarter to work on having the list figure out it's own correct/canonical names on it's own by finding other values that match within a certain "edit distance" and weigh them based on the count property. I hope it doesn't need to go there.

good-praxis pushed a commit that referenced this issue Oct 21, 2018
bhousel pushed a commit that referenced this issue Oct 29, 2018
bhousel pushed a commit that referenced this issue Feb 13, 2019
bhousel pushed a commit that referenced this issue Mar 31, 2019
Added wiki tags for First Bank
bhousel pushed a commit that referenced this issue Jun 29, 2019
fixes #1
bhousel pushed a commit that referenced this issue Jun 29, 2019
fixes #1
bhousel pushed a commit that referenced this issue Jul 1, 2019
Merge pull request - updating master
tas50 pushed a commit that referenced this issue Oct 15, 2019
ENT8R referenced this issue in ENT8R/name-suggestion-index Feb 29, 2020
bhousel pushed a commit that referenced this issue Oct 2, 2020
bhousel pushed a commit that referenced this issue Oct 2, 2020
bhousel pushed a commit that referenced this issue Oct 5, 2020
get up-to-date comments
Identitaet pushed a commit that referenced this issue Oct 9, 2020
bhousel pushed a commit that referenced this issue Oct 11, 2020
update my fork master branch
bhousel pushed a commit that referenced this issue Oct 15, 2020
syncing with upstream
bhousel pushed a commit that referenced this issue Oct 22, 2020
tas50 pushed a commit that referenced this issue Oct 25, 2020
bhousel pushed a commit that referenced this issue Oct 26, 2020
Merge changes from original repo
bhousel pushed a commit that referenced this issue Jan 21, 2021
bhousel pushed a commit that referenced this issue Feb 21, 2021
Identitaet pushed a commit that referenced this issue Mar 9, 2021
LaoshuBaby added a commit that referenced this issue Mar 20, 2021
Sync with upstream before new commit
LaoshuBaby pushed a commit that referenced this issue Mar 25, 2021
arch0345 added a commit that referenced this issue Aug 10, 2021
bhousel pushed a commit that referenced this issue Sep 12, 2021
LaoshuBaby pushed a commit that referenced this issue Sep 14, 2021
UKChris-osm pushed a commit that referenced this issue Sep 7, 2023
Update bicycle_rental (french only)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant