We should add local name:xx tags

[bhousel]

In working with KeepRight data a lot lately, I notice that it sometimes flags a warning like this:

It would be nice if this node had an additional tag 'name:XX=Chick-fil-A' where XX shows the language of its name 'Chick-fil-A'.

It seems like the warning is caused if someone adds a name:xx tag and a name and they don't match.

It is only a warning , but I can understand why it would be nice in this case to add a name:en tag, so that people know what language name is in or where it came from.

We have a lot of names like this in the index. Our Contributing guidelines even encourage it:

  "amenity/fast_food|マクドナルド": {         // Identifier like "key/value|name"
    "count": 1445,
    "countryCodes": ["jp"],                 // Optional `countryCodes` - array of countries where this entry is used
    "tags": {
      "amenity": "fast_food",
      "brand": "マクドナルド",                // `brand` - Brand name in the local language (Japanese)
      "brand:en": "McDonald's",             // `brand:en` - For non-English brands, tag the English version too
      "brand:wikidata": "Q38076",           // `brand:wikidata` - Same Universal wikidata identifier
      "brand:wikipedia": "ja:マクドナルド",   // `brand:wikipedia` - Reference to Japanese Wikipedia
      "cuisine": "burger",
      "name": "マクドナルド",                 // `name` - Display name, also in the local language (Japanese)
      "name:en": "McDonald's"               // `name:en` - For non-English names, tag the English version too
     // SHOULD WE ADD "name:ja" TOO??
    }
  },

[kymckay]

I can't think of any strong argument against it 👍

[matkoniecz]

from what I see there is no pending issue to remove this complaint in https://github.com/keepright/keepright/issues (I checked as Keep Right is no longer developed).

[matkoniecz]

JOSM also complains (at information level)

For example shop=car, name=ホンダ, name:en=Honda node gets

Missing name:* translation - Missing name:*=ホンダ. Add tag with correct language key. (1)

So I think that it would be OK to add also name:<local>.

[kymckay]

The only minor complaint I can think of is that it is basically duplicating a bunch of data 🤔 If the name changes you then change it in two places.

However that's more of an issue with the accepted tagging scheme. Seems more logical to me to just have a language:name=en tag to specify the language of the name tag.

[bhousel]

It sounds like if both JOSM and KeepRight warn users about it, we should just add the local name tag. Our goal with this project is to help people map stuff the best way possible. 😄

[sommerluk]

For “Burger King” for example it's the same name in French, German and Englisch. In Germany I would expect rather to find a :de while in France I would expect rather a :fr on an object…

[bhousel]

For “Burger King” for example it's the same name in French, German and Englisch. In Germany I would expect rather to find a :de while in France I would expect rather a :fr on an object…

For that example, we wouldn't set any name:xx tag.

This issue is saying if we set a name:xx tag, make sure there exists a name:xx tag that matches the name tag.

[kymckay]

Oh that makes more sense, I also misunderstood this and thought those warnings wanted name:xx on everything 😆

[bhousel]

I've updated the CONTRIBUTING doc and also added name:xx and brand:xx tags for situations where the language used is unambiguous. Rule going forward is as stated above:

• "If we set a name:xx tag, make sure there exists a name:xx tag that matches the name tag."
• "If we set a brand:xx tag, make sure there exists a brand:xx tag that matches the brand tag."
• etc..

This should keep people happy! It means there is a lot of work to do in the index to add these tags, but I could add a build warning to assist cleanup.

[matkoniecz]

I could add a build warning to assist cleanup.

That would be very useful! Half of my contributions were prompted by spotting a warning in a build output, it also finds typos.