Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flags 🇺🇳 #4745

Closed
bhousel opened this issue Dec 1, 2020 · 8 comments
Closed

Flags 🇺🇳 #4745

bhousel opened this issue Dec 1, 2020 · 8 comments

Comments

@bhousel
Copy link
Member

bhousel commented Dec 1, 2020

I have some free time while I wait for the planet to download, so I'm going to add a tree for flags.
These are features in OSM that map nicely to Wikidata - @1ec5 has already done all the hard work here. 👏

For our purposes
k/v will be man_made/flagpole - https://wiki.openstreetmap.org/wiki/Tag:man_made%3Dflagpole
and n will be flag:name - https://wiki.openstreetmap.org/wiki/Key:flag:name

Yarrr! 🏴‍☠️

@bhousel
Copy link
Member Author

bhousel commented Dec 1, 2020

Also, some things I forgot to mention

  • As of today there isn't enough seed data in OSM to collect flag:name from OSM planet files (see taginfo). These will be much easier to map eventually when NSI can generate editor presets for them.
  • I'm just going to set all the locationSets to { include: ['001'] } - any flag can validly be flown anywhere in the world.

@bhousel
Copy link
Member Author

bhousel commented Dec 1, 2020

@Identitaet people have proposed species tagging before, and we may do it someday, but this issue is about flags. 🏴
Species tagging is infinitely complicated, but flags are easy as there are only a few hundred of them.

@Identitaet
Copy link
Collaborator

oh wait I misread a tree for flags as trees OR flags

bhousel added a commit that referenced this issue Dec 1, 2020
@1ec5
Copy link
Member

1ec5 commented Dec 1, 2020

flags are easy as there are only a few hundred of them

This Wikidata Query Service query returns the name, type, subject, and image of about 4,200 flags in Wikidata, not all of which have been tagged in OSM yet. It only returns freely licensed images from Wikimedia Commons; there’s also a non-free image URL property, but there’d be no guarantee about the quality of those images, licensing issues aside.

@1ec5
Copy link
Member

1ec5 commented Dec 1, 2020

and n will be flag:name

How will the index handle the fact that flag:name is supposed to be in the local language? Would that part of the feature be localizable? Unlike with brands, flag names tend to have just as many translated names as the represented places or organizations would. For what it’s worth, flag:name is mostly intended to be a fallback for when there’s no Wikidata entity, though it’s harmless in cases where there is a Wikidata entity.

@bhousel
Copy link
Member Author

bhousel commented Dec 1, 2020

flags are easy as there are only a few hundred of them

[This Wikidata Query Service query] returns the name, type, subject, and image of about 4,200 flags in Wikidata,

Awesome! I just took a look... Maybe we can narrow it down and grab just the country/region/military ones?
4200 is a lot..(but still a lot more managable than all species)

@bhousel
Copy link
Member Author

bhousel commented Dec 1, 2020

How will the index handle the fact that flag:name is supposed to be in the local language? Would that part of the feature be localizable?

I wasn't expecting to localize it, but we can pick whatever we want that tag to contain (and we can add matchName for variants that we want a validator to match)

@bhousel bhousel closed this as completed in de7e1fa Dec 1, 2020
@bhousel
Copy link
Member Author

bhousel commented Dec 1, 2020

OK, the flags we know about are on nsi.guide now, but looks like the convention is to use P18 "image" , so I'm reopening this because I need to:

  • update build_wikidata.js script to grab P18 "image" instead of P154 "logo image" (for flags)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants