Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix GitHub Chalk #7283

Merged
merged 3 commits into from
Oct 30, 2022
Merged

Fix GitHub Chalk #7283

merged 3 commits into from
Oct 30, 2022

Conversation

peternewman
Copy link
Collaborator

@peternewman peternewman commented Oct 29, 2022 •
edited
Loading

@peternewman peternewman mentioned this pull request Oct 29, 2022
Merged
@peternewman peternewman changed the title Test location validation Fix GitHub Chalk Oct 29, 2022
@bhousel
Copy link
Member

bhousel commented Oct 29, 2022

Looks good! This is what was expected right?

Screen Shot 2022-10-29 at 12 38 11 PM

@peternewman peternewman marked this pull request as ready for review October 29, 2022 18:00
@peternewman
Copy link
Collaborator Author

Looks good! This is what was expected right?

I assume so 🤷 It's definitely more colourful than it used to be without the change! Seems to tie up with what the code is trying to do too...

@UKChris-osm UKChris-osm merged commit 945ad3b into main Oct 30, 2022
@UKChris-osm UKChris-osm deleted the peternewman-test-location-validation branch October 30, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peternewman @bhousel @UKChris-osm