Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine bindings #2 #14

Merged
merged 7 commits into from
Mar 17, 2022
Merged

Refine bindings #2 #14

merged 7 commits into from
Mar 17, 2022

Conversation

maurolacy
Copy link
Collaborator

@maurolacy maurolacy commented Mar 16, 2022

Related to confio/osmosis#4. Some changes required for implementing EstimatePrice:

@maurolacy maurolacy self-assigned this Mar 16, 2022
Copy link
Collaborator

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the code refactor.

I do not agree with the type changes. I would revert both.
You can merge with just the logic refactor or add the sender parameter as we seem to need that more than anything.

packages/bindings/src/types.rs Outdated Show resolved Hide resolved
packages/bindings/src/query.rs Outdated Show resolved Hide resolved
packages/bindings-test/src/multitest.rs Show resolved Hide resolved
@maurolacy maurolacy merged commit f7365d5 into main Mar 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants