Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable logging for when iavl storage is performing an upgrade #103

Merged
merged 5 commits into from
Feb 11, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Feb 8, 2022

Description

Background

We would like to info log the upgrade in progress so that users are aware of it happening. Otherwise, it may take more than 30 minutes to complete and leave users thinking that the SDK is stuck.

Acceptance Criteria

  • logger is propagated to iavl
  • log is added
  • all unit tests keep passing

Closes: #XXXX


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

store/iavl/store.go Outdated Show resolved Hide resolved
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks great to me! Just some comments on the log message

@ValarDragon
Copy link
Member

No need to block merge on those logs changing btw. We can just change those in a second PR

p0mvn and others added 3 commits February 10, 2022 20:19
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
@p0mvn p0mvn merged commit af99d61 into roman/v0.44.3x-osmo-v5-fast.3 Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants