Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: safe guard gRPC size limits #220

Merged
merged 1 commit into from
May 6, 2022

Conversation

alexanderbez
Copy link
Collaborator

Description

The newly introduced configurable gRPC size limits would cause operators using the old config to treat these new values as 0, rightfully so as they do no exist in config. This requires operators to update their configs. This PR adds an extra safe guard such that if they do not update, the default values will still be used.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

Copy link
Member

@p0mvn p0mvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@alexanderbez alexanderbez merged commit 4ede62c into osmosis-main May 6, 2022
@alexanderbez alexanderbez deleted the bez/grpc-size-limits-safe-guard branch May 6, 2022 13:29
mergify bot pushed a commit that referenced this pull request May 6, 2022
mergify bot pushed a commit that referenced this pull request May 6, 2022
(cherry picked from commit 4ede62c)

# Conflicts:
#	server/config/config.go
#	server/grpc/server.go
#	server/start.go
alexanderbez pushed a commit that referenced this pull request May 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants