Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: snapshot manager is created independently from snapshot-int… #236

Merged
merged 3 commits into from
May 12, 2022
Merged

refactor: snapshot manager is created independently from snapshot-int… #236

merged 3 commits into from
May 12, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented May 12, 2022 •
edited
Loading

Closes: #235

What is the purpose of the change

Earlier snapshot refactor made state-sync work only when snapshot-interval is > 0. State-sync should be enabled even when a snapshot-interval is 0. This PR makes it so.

Testing and Verifying

This change is already covered by existing tests, such as (please describe tests).

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? yes
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@p0mvn p0mvn marked this pull request as ready for review May 12, 2022 20:16
@p0mvn p0mvn requested a review from a team May 12, 2022 20:16
@czarcas7ic
Copy link
Member

Would you like me to PR this on v7.x as well to test on mainnet?

@p0mvn
Copy link
Member Author

p0mvn commented May 12, 2022

Would you like me to PR this on v7.x as well to test on mainnet?

Thank you but I don't think this change is risky so we can just proceed with it on v8

@alexanderbez alexanderbez merged commit 0041954 into osmosis-main May 12, 2022
@alexanderbez alexanderbez deleted the roman/state-sync branch May 12, 2022 23:36
@mergify mergify bot mentioned this pull request Jun 7, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jun 7, 2022
@p0mvn @mergify
refactor: snapshot manager is created independently from snapshot-int… (
bddfa19 
#236)

(cherry picked from commit 0041954)
@p0mvn p0mvn mentioned this pull request Jun 7, 2022
Closed
p0mvn added a commit that referenced this pull request Jun 7, 2022
@mergify @p0mvn
refactor: snapshot manager is created independently from snapshot-int… (
743adc9 
#236) (#255)

(cherry picked from commit 0041954)

Co-authored-by: Roman <roman@osmosis.team>
@p0mvn p0mvn mentioned this pull request Jun 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderbez alexanderbez alexanderbez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor: decouple snapshot-interval from state-sync
3 participants
@p0mvn @czarcas7ic @alexanderbez