Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: expose SetAppVersion on the upgrade keeper #244

Merged
merged 1 commit into from
May 24, 2022
Merged

refactor: expose SetAppVersion on the upgrade keeper #244

merged 1 commit into from
May 24, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented May 23, 2022 •
edited
Loading

Closes: #XXX

What is the purpose of the change

exposes SetAppVersion() on the upgrade keeper so that we can overwrite it to a higher number during upgrade

Testing and Verifying

This change is already covered by existing tests

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@p0mvn p0mvn changed the title refactor: expsoe SetAppVersion on the upgrade keeper to allow overwri… refactor: expose SetAppVersion on the upgrade keeper May 24, 2022
@p0mvn p0mvn marked this pull request as ready for review May 24, 2022 14:48
@p0mvn p0mvn requested a review from a team May 24, 2022 14:48
@ValarDragon ValarDragon merged commit 9a05fa0 into osmosis-main May 24, 2022
@ValarDragon ValarDragon deleted the roman/set-app-version branch May 24, 2022 15:08
mergify bot pushed a commit that referenced this pull request May 24, 2022
@p0mvn @mergify
refactor: expsoe SetAppVersion on the upgrade keeper to allow overwri…
b4a3240 
…ting during the upgrade (#244)

(cherry picked from commit 9a05fa0)
@mergify mergify bot mentioned this pull request May 24, 2022
Merged
p0mvn added a commit that referenced this pull request May 24, 2022
@mergify @p0mvn
refactor: expsoe SetAppVersion on the upgrade keeper to allow overwri…
830f277 
…ting during the upgrade (#244) (#245)

(cherry picked from commit 9a05fa0)

Co-authored-by: Roman <roman@osmosis.team>
@p0mvn p0mvn mentioned this pull request Jun 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon approved these changes

Assignees
No one assigned
Labels
C:x/upgrade
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0mvn @ValarDragon