Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase maxApproxRootIterations to 300 #262

Conversation

catShaark
Copy link

Closes: #XXX

What is the purpose of the change

Increase the number of iterations in ApproxRoot so that it returns correct value for large sdk.Dec input

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not documented

@catShaark catShaark requested a review from a team June 11, 2022 20:46
@czarcas7ic czarcas7ic merged commit 7ae03dd into osmosis-labs:osmosis-main Jun 11, 2022
mergify bot pushed a commit that referenced this pull request Jun 11, 2022
ValarDragon pushed a commit that referenced this pull request Jun 11, 2022
(cherry picked from commit 7ae03dd)

Co-authored-by: khanh <50263489+catShaark@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants