Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extra app hash logs #500

Merged
merged 3 commits into from
Jan 6, 2024
Merged

Conversation

czarcas7ic
Copy link
Member

@czarcas7ic czarcas7ic commented Jan 3, 2024

Utilizes error channels from cometBFT to trigger additional logging when app hashes occur of every module's hash at the problematic block height.

Screenshot 2024-01-02 at 9 58 28 PM

The respective cometBFT PR: osmosis-labs/cometbft#1

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK, but we also want to dump block_results as well

Can be a different PR!

@czarcas7ic czarcas7ic merged commit 7ff0763 into osmo/v0.47.5 Jan 6, 2024
14 of 25 checks passed
@czarcas7ic czarcas7ic deleted the adam/osmo/v0.47.5-app-hash-print branch January 6, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants