fix: add old supply offset functions #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
czarcas7ic
reviewed
Oct 2, 2024
Comment on lines
+38
to
+41
|
|
||
| // SupplyOffKeyOld is a Osmosis specific key that handles supply offsets pre v0.50 | ||
| // TODO: Remove in the v28 upgrade | ||
| SupplyOffsetKeyOld = []byte{0x88} |
There was a problem hiding this comment.
I just want to verify that you checked NewPrefix 88 does not collide with []byte{0x88}
There was a problem hiding this comment.
Yeah I did, this is the bug
czarcas7ic
approved these changes
Oct 2, 2024
Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Exposing functions to allow Osmosis to access the old supply offsets
Osmosis PR => osmosis-labs/osmosis#8751