Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable limit order tests for EU #3744

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Enable limit order tests for EU #3744

merged 2 commits into from
Aug 16, 2024

Conversation

yury-dubinin
Copy link
Contributor

What is the purpose of the change:

  • Enable limit order tests for EU as a separate job

@yury-dubinin yury-dubinin self-assigned this Aug 15, 2024
Copy link

vercel bot commented Aug 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
osmosis-frontend ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 15, 2024 5:49pm
4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
osmosis-frontend-datadog ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2024 5:49pm
osmosis-frontend-dev ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2024 5:49pm
osmosis-frontend-edgenet ⬜️ Ignored (Inspect) Aug 15, 2024 5:49pm
osmosis-testnet ⬜️ Ignored (Inspect) Visit Preview Aug 15, 2024 5:49pm

Copy link
Contributor

coderabbitai bot commented Aug 15, 2024

Walkthrough

The recent changes enhance the GitHub Actions workflow by introducing a new job, fe-trade-eu-tests, dedicated to end-to-end testing for EU trade functionality. This job includes several steps for environment setup, Playwright installation, and executing tests with appropriate configurations. Furthermore, the delete-deployments job has been updated to depend on the successful completion of the new test job, strengthening the CI/CD pipeline. A parameter in the test itself was also adjusted to better align with the new monitoring context.

Changes

Files Change Summary
.github/workflows/monitoring-geo-e2e-tests.yml Added a new job fe-trade-eu-tests for EU trade testing; updated delete-deployments job dependencies and Slack alert messages.
packages/web/e2e/tests/monitoring.wallet.spec.ts Changed wallet name in setWalletNameAndPassword method from "Test Filled Trades" to "Monitoring E2E Tests".

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between d589456 and 6b950b6.

Files selected for processing (1)
  • .github/workflows/monitoring-geo-e2e-tests.yml (2 hunks)
Additional comments not posted (2)
.github/workflows/monitoring-geo-e2e-tests.yml (2)

298-309: Modification to delete-deployments job enhances dependency management.

Including fe-trade-eu-tests in the job dependencies ensures proper sequencing and strengthens the CI/CD pipeline.


225-297: Addition of fe-trade-eu-tests job is well-structured.

The job follows a consistent pattern with other jobs in the workflow and includes necessary steps for setup, execution, and alerting.

Ensure that the required secrets (TEST_PROXY_USERNAME, TEST_PROXY_PASSWORD, TEST_PRIVATE_KEY_2, SERVER_E2E_TESTS_SLACK_WEBHOOK_URL) are available in the repository settings.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@yury-dubinin yury-dubinin requested a review from a team August 15, 2024 18:01
@yury-dubinin yury-dubinin merged commit df162b3 into stage Aug 16, 2024
41 checks passed
@yury-dubinin yury-dubinin deleted the enable-trade branch August 16, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants