Add Transmuter Contract Codes #3749
Conversation
|
@JohnnyWyles is attempting to deploy a commit to the OsmoLabs Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe recent update enhances the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant FeatureFlagService
participant App
Client->>FeatureFlagService: Request TransmuterPoolCodeIds
FeatureFlagService->>App: Check Environment (IS_TESTNET)
alt IS_TESTNET
App-->>FeatureFlagService: Return ["3084"]
else
App-->>FeatureFlagService: Return ["148", "814", "867", "996"]
end
FeatureFlagService-->>Client: Provide TransmuterPoolCodeIds
Recent review detailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Outside diff range, codebase verification and nitpick comments (1)
packages/web/config/feature-flag.ts (1)
26-26: Inconsistent Usage ofTransmuterPoolCodeIdsAcross EnvironmentsThe
TransmuterPoolCodeIdsis used in both the client and server code, but there is an inconsistency in the IDs used across these environments. The server-side code does not include the new IDs ("814", "867", "996") added to the client-side configuration.
- File:
packages/server/src/queries/complex/pools/env.ts
- Line:
const TransmuterPoolCodeIds = IS_TESTNET ? ["3084"] : ["148"];Ensure that the server-side logic is updated to reflect the same set of IDs as the client-side configuration to maintain consistency across environments.
Analysis chain
LGTM! But verify the usage of new TransmuterPoolCodeIds.
The addition of new IDs to
TransmuterPoolCodeIdsis consistent with the objective of enhancing filtering capabilities. Ensure that these new IDs are correctly utilized in the application logic.To verify, ensure that the application logic correctly handles these new IDs.
Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify the usage of new TransmuterPoolCodeIds in the codebase. # Test: Search for occurrences of the new IDs. Expect: Usage in relevant logic. rg --type js '814|867|996'Length of output: 111376
Script:
#!/bin/bash # Description: Search for the usage of TransmuterPoolCodeIds in the source files. # Test: Search for occurrences of TransmuterPoolCodeIds. Expect: Usage in relevant logic. rg --type js 'TransmuterPoolCodeIds'Length of output: 36
Script:
#!/bin/bash # Description: Search for the usage of TransmuterPoolCodeIds across all file types. # Test: Search for occurrences of TransmuterPoolCodeIds in all files. Expect: Usage in relevant logic. rg 'TransmuterPoolCodeIds'Length of output: 471
Adding the 3 other contract uploads for Transmuter pools so that these can be filtered out in the pools list if wanted.
Transmuter 1.0 already listed
Transmuter 2.0 was never instantiated
This adds 3.0, 3.1 and 3.2 which are the alloyed asset pools - but also are transmuters and often dominate the volume charts.