Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename fields in QuerySpotPriceRequest #1227

Closed
ValarDragon opened this issue Apr 8, 2022 · 0 comments · Fixed by #1228
Closed

Rename fields in QuerySpotPriceRequest #1227

ValarDragon opened this issue Apr 8, 2022 · 0 comments · Fixed by #1228
Assignees
@alexanderbez
Labels
C:x/gamm Changes, features and bugs related to the gamm module.

Comments

@ValarDragon
Copy link
Member

As noted in the keeper and breaking change notes, we intended to break the name of tokenInDenom and tokenOutDenom in QuerySpotPriceRequest.

@imperator-co pointed out that we actually just forgot to do this.

we need to change: https://github.com/osmosis-labs/osmosis/blob/main/proto/osmosis/gamm/v1beta1/query.proto#L125-L127 to be quoteAssetDenom and baseAssetDenom respectively. We also need to update relevant code comments / docs for querying spot price.
@ValarDragon ValarDragon added the C:x/gamm Changes, features and bugs related to the gamm module. label Apr 8, 2022
@ValarDragon ValarDragon moved this to 🔍 Needs Review in Osmosis Chain Development Apr 8, 2022
@alexanderbez alexanderbez self-assigned this Apr 8, 2022
@alexanderbez alexanderbez mentioned this issue Apr 8, 2022
Merged
4 tasks
Repository owner moved this from 🔍 Needs Review to ✅ Done in Osmosis Chain Development Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexanderbez alexanderbez

Labels
C:x/gamm Changes, features and bugs related to the gamm module.
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor: rename SpotPrice gRPC proto fields osmosis-labs/osmosis
2 participants
@alexanderbez @ValarDragon