refactor: rename SpotPrice gRPC proto fields #1228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
added
C:gRPC
alexanderbez
commented
Apr 8, 2022
Comment on lines
+120
to
+121
| string base_asset_denom = 2 [(gogoproto.moretags) = "yaml:\"base_asset_denom\""]; | ||
| string quote_asset_denom = 3 [(gogoproto.moretags) = "yaml:\"quote_asset_denom\""]; |
There was a problem hiding this comment.
reviewer: logical proto changes
Codecov Report
@@ Coverage Diff @@
## main #1228 +/- ##
==========================================
- Coverage 20.99% 20.96% -0.03%
==========================================
Files 196 196
Lines 25345 25337 -8
==========================================
- Hits 5320 5312 -8
Misses 19066 19066
Partials 959 959
Continue to review full report at Codecov.
|
ValarDragon
approved these changes
Apr 8, 2022
| @@ -201,51 +200,86 @@ func (suite *KeeperTestSuite) TestQueryBalancerPoolTotalLiquidity() { | |||
| // suite.Require().Equal("5000000foo", PoolAssets[2].Token.String()) | |||
| // } | |||
|
|
|||
| // TODO: Come back and make this table driven | |||
| func (suite *KeeperTestSuite) TestQueryBalancerPoolSpotPrice() { | |||
There was a problem hiding this comment.
Thank you for improving this test 🙏
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1227
Description
SpotPricegRPC proto fieldsTestQueryBalancerPoolSpotPriceTDFor contributor use:
docs/) or specification (x/<module>/spec/)Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorer