Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: e2e test superfluid gov voting #1556

Closed
p0mvn opened this issue May 21, 2022 · 1 comment
Closed

test: e2e test superfluid gov voting #1556

p0mvn opened this issue May 21, 2022 · 1 comment
Assignees
@czarcas7ic
Labels
frog🐸 T:tests

Comments

@p0mvn
Copy link
Member

p0mvn commented May 21, 2022

Background

We should convert this manual test case to an e2e test: #1543 (comment)

Suggested Design

  • introduce `func (s *IntegrationTestSuite) TestSuperfluidGovVoting() {...}
  • Reproduce the listed commands by calling them via Docker test in e2e_test.go
  • add a test where there is no SF delegation and assert that only validator has voted
  • add a test where a non-superfluid (regular) staker votes and ensure that the vote is overridden

Acceptance Criteria

  • the manual test is fully converted to e2e
  • similar test with no SF delegation is added and passes
  • similar test with a regular staker added
  • all new and existing tests pass
@p0mvn p0mvn added the T:tests label May 21, 2022
@p0mvn p0mvn moved this to Needs Review 🔍 in Osmosis Chain Development May 21, 2022
@p0mvn p0mvn moved this from Needs Review 🔍 to Todo 🕒 in Osmosis Chain Development May 21, 2022
@p0mvn p0mvn added the frog🐸 label May 21, 2022
@p0mvn p0mvn mentioned this issue May 21, 2022
Merged
mergify bot pushed a commit that referenced this issue May 21, 2022
@p0mvn
fix: gov support for superfluid (#1555)
8aaa84b 
Closes: #XXX

## What is the purpose of the change

@czarcas7ic and I ran into issues manually testing #1191 . We both reproduces this test case: #1543 (comment)

Upon further investigation, it was found that staking keeper was never replaced with superfluid keeper in the gov module so that the new logic could not be used for calculating tally and overriding validator votes by SF stakers.

We need to e2e test this case in a future PR: #1556

## Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

## Documentation and Release Note

  - Does this pull request introduce a new feature or user-facing behavior changes? no
  - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? no
  - How is the feature or change documented? not applicable
mergify bot pushed a commit that referenced this issue May 21, 2022
@p0mvn @mergify
fix: gov support for superfluid (#1555)
fbb334a 
Closes: #XXX

## What is the purpose of the change

@czarcas7ic and I ran into issues manually testing #1191 . We both reproduces this test case: https://github.com/osmosis-labs/osmosis/discussions/1543#discussioncomment-2786650

Upon further investigation, it was found that staking keeper was never replaced with superfluid keeper in the gov module so that the new logic could not be used for calculating tally and overriding validator votes by SF stakers.

We need to e2e test this case in a future PR: #1556

## Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

## Documentation and Release Note

  - Does this pull request introduce a new feature or user-facing behavior changes? no
  - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? no
  - How is the feature or change documented? not applicable

(cherry picked from commit 8aaa84b)
p0mvn added a commit that referenced this issue May 21, 2022
@mergify @p0mvn
fix: gov support for superfluid (#1555) (#1557)
428b9d8 
Closes: #XXX

## What is the purpose of the change

@czarcas7ic and I ran into issues manually testing #1191 . We both reproduces this test case: https://github.com/osmosis-labs/osmosis/discussions/1543#discussioncomment-2786650

Upon further investigation, it was found that staking keeper was never replaced with superfluid keeper in the gov module so that the new logic could not be used for calculating tally and overriding validator votes by SF stakers.

We need to e2e test this case in a future PR: #1556

## Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

## Documentation and Release Note

  - Does this pull request introduce a new feature or user-facing behavior changes? no
  - Is a relevant changelog entry added to the `Unreleased` section in `CHANGELOG.md`? no
  - How is the feature or change documented? not applicable

(cherry picked from commit 8aaa84b)

Co-authored-by: Roman <roman@osmosis.team>
@czarcas7ic
Copy link
Member

Closed via #1586

Repository owner moved this from Todo 🕒 to Done ✅ in Osmosis Chain Development May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@czarcas7ic czarcas7ic

Labels
frog🐸 T:tests
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@p0mvn @czarcas7ic