Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(x/gov): expedited proposals parameter migrations #2249

Closed
p0mvn opened this issue Jul 28, 2022 · 3 comments · Fixed by osmosis-labs/cosmos-sdk#303
Closed

refactor(x/gov): expedited proposals parameter migrations #2249

p0mvn opened this issue Jul 28, 2022 · 3 comments · Fixed by osmosis-labs/cosmos-sdk#303

Comments

@p0mvn
Copy link
Member

p0mvn commented Jul 28, 2022

Background

For expedited proposals we added 2 new parameters:

However, these parameters have not been set / migrated to. We need to implement the migrations to set the parameters to the desired values according to: https://wallet.keplr.app/chains/osmosis/proposals/278 and its respective common wealth thread.

When the migrations are implemented in the SDK fork, we need to upgrade our go.mod in Osmosis. As long as the e2e upgrade test passes, the migrations are done correctly and this change is complete.

Suggested Design

For reference how the migrations can be done, it is possible to reference:

From #296, we need a similar change to x/gov/legacy/v3 package. This time, we need to make a new v4 package. Additionally. we need to increase the gov module's consensus version to v4

From #298, we need similar boilerplate to enable migrations. The two PRs were split because the changes in #298 were missed and caught in tests. Ideally, these should have been a single PR.

This is a Cosmos-SDK fork change. Openining up issue here because it needs to be updated with this change to unblock #2087.

Acceptance Criteria

  • expedited proposal parameter migrations are implemented in the SDK fork
  • parameters are set to the desired values from the gov prop
  • the upgraded sdk change is integrated into Osmosis
  • e2e upgrade tests continue to pass
@p0mvn
Copy link
Member Author

p0mvn commented Jul 28, 2022

@xBalbinus would you like to work on this? This is a pre-requisite to #2087 that you were interested in picking up

@xBalbinus
Copy link
Contributor

Yeah you got it! For sure. I can pick this up early next week - I'm trying to wrap up some inline docs with the pool-incentives audit (and just general things on that end) atm

@xBalbinus
Copy link
Contributor

May be closed by osmosis-labs/cosmos-sdk#303

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment