Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(x/gov): migrations from 2 to 3 (min proposer deposit) #298

Merged
merged 2 commits into from
Jul 27, 2022
Merged

fix(x/gov): migrations from 2 to 3 (min proposer deposit) #298

merged 2 commits into from
Jul 27, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Jul 27, 2022

Closes: #XXX

What is the purpose of the change

This issue was discovered while e2e testing upgrades. This fix helps to resolve the problems with x/gov migrations.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@p0mvn p0mvn marked this pull request as ready for review July 27, 2022 21:37
@p0mvn p0mvn requested a review from a team July 27, 2022 21:37
czarcas7ic
czarcas7ic approved these changes Jul 27, 2022
View reviewed changes
Copy link
Member

@czarcas7ic czarcas7ic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you said, E2E would catch any migration errors! Awesome to see it working as intended, gj 😄

@p0mvn p0mvn merged commit 51bfa90 into osmosis-main Jul 27, 2022
@p0mvn p0mvn deleted the roman/fix-gov-migrations branch July 27, 2022 22:16
mergify bot pushed a commit that referenced this pull request Jul 27, 2022
@p0mvn @mergify
fix(x/gov): migrations from 2 to 3 (min proposer deposit) (#298)
ebdf2c3 
* git checkout -b roman/fix-gov-migrations

* register migrations

(cherry picked from commit 51bfa90)

# Conflicts:
#	x/gov/legacy/v3/store.go
@mergify mergify bot mentioned this pull request Jul 27, 2022
Closed
p0mvn added a commit that referenced this pull request Jul 27, 2022
@p0mvn
fix(x/gov): migrations from 2 to 3 (min proposer deposit) (#298)
65cfb7d 
* git checkout -b roman/fix-gov-migrations

* register migrations
@p0mvn p0mvn mentioned this pull request Jul 27, 2022
Merged
p0mvn added a commit that referenced this pull request Jul 28, 2022
@p0mvn
fix(x/gov): migrations from 2 to 3 (min proposer deposit) (#298) (#302)
f09814c 
* git checkout -b roman/fix-gov-migrations

* register migrations
This was referenced Jul 28, 2022
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czarcas7ic czarcas7ic czarcas7ic approved these changes

Assignees
No one assigned
Labels
A:Automerge C:x/gov
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0mvn @czarcas7ic