Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate osmobuilder and remove contrib folder #2482

Closed
2 tasks done
niccoloraspa opened this issue Aug 22, 2022 · 2 comments · Fixed by #2494
Closed
2 tasks done

Deprecate osmobuilder and remove contrib folder #2482

niccoloraspa opened this issue Aug 22, 2022 · 2 comments · Fixed by #2494
Assignees
@niccoloraspa

Comments

@niccoloraspa
Copy link
Member

niccoloraspa commented Aug 22, 2022 •
edited
Loading

Background

#2427 deprecates osmobuilder as now we can use the Makefile and the Dockerfile for reproducible osmosisd builds.

Deprecating osmobuilder, also allows deprecating the whole contrib as it contains un-used sdk docker images and scripts.
Only https://github.com/osmosis-labs/osmosis/blob/main/contrib/scripts/check-generated.sh seems to be used, but it can be moved in the scripts folder or integrated into the workflow that's using it.

Acceptance Criteria

  • osmobuilder removed from the release process
  • contrib folder deleted from main repo, with the check-generated.sh script moved somewhere
@niccoloraspa niccoloraspa self-assigned this Aug 22, 2022
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Aug 22, 2022
@niccoloraspa niccoloraspa mentioned this issue Aug 23, 2022
Merged
@niccoloraspa
Copy link
Member Author

First task completed:

@niccoloraspa niccoloraspa added A:backport/v11.x backport patches to v11.x branch and removed A:backport/v11.x backport patches to v11.x branch labels Aug 23, 2022
@niccoloraspa niccoloraspa mentioned this issue Aug 23, 2022
Merged
@niccoloraspa
Copy link
Member Author

Second task completed:
#2494

Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Aug 23, 2022
@niccoloraspa niccoloraspa mentioned this issue Aug 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niccoloraspa niccoloraspa

Labels
None yet
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate osmobuilder and remove contrib folder [2/2] osmosis-labs/osmosis
1 participant
@niccoloraspa