Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate osmobuilder and remove contrib folder [1/2] #2493

Merged
merged 1 commit into from
Aug 23, 2022
Merged

Deprecate osmobuilder and remove contrib folder [1/2] #2493

merged 1 commit into from
Aug 23, 2022

Conversation

niccoloraspa
Copy link
Member

@niccoloraspa niccoloraspa commented Aug 23, 2022 •
edited
Loading

Related issue: #2482
Addresses first task

What is the purpose of the change

This PR makes small changes to the make build-reproducible command to adapt it to the new release process.
The new release process doesn't use osmobuilder anymore, so we can finally deprecate it.

The new release process is complete and can be seen here.

Brief Changelog

  • Small changes to Makefile

Testing and Verifying

Changes are trivial.
I have tested the workflow by creating a fake release.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? not applicable

@niccoloraspa niccoloraspa requested a review from a team August 23, 2022 12:33
@niccoloraspa niccoloraspa mentioned this pull request Aug 23, 2022
Closed
2 tasks
@niccoloraspa niccoloraspa added the A:backport/v11.x backport patches to v11.x branch label Aug 23, 2022
@niccoloraspa niccoloraspa mentioned this pull request Aug 23, 2022
Merged
p0mvn
p0mvn reviewed Aug 23, 2022
View reviewed changes
Makefile Show resolved Hide resolved
@p0mvn p0mvn merged commit d2a1649 into main Aug 23, 2022
@p0mvn p0mvn deleted the nicco/improve-reproducible-builds branch August 23, 2022 15:51
mergify bot pushed a commit that referenced this pull request Aug 23, 2022
@niccoloraspa @mergify
Add small fixes (#2493)
bf2c5f2 
(cherry picked from commit d2a1649)
@mergify mergify bot mentioned this pull request Aug 23, 2022
Merged
p0mvn pushed a commit that referenced this pull request Aug 23, 2022
@mergify @niccoloraspa
Add small fixes (#2493) (#2495)
4d0ebc5 
(cherry picked from commit d2a1649)

Co-authored-by: Niccolo Raspa <6024049+niccoloraspa@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@p0mvn p0mvn p0mvn approved these changes

Assignees
No one assigned
Labels
A:backport/v11.x backport patches to v11.x branch T:build
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niccoloraspa @p0mvn