Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL][Swap Router Module]: implement foundational structure #3049

Closed
p0mvn opened this issue Oct 18, 2022 · 2 comments
Closed

[CL][Swap Router Module]: implement foundational structure #3049

p0mvn opened this issue Oct 18, 2022 · 2 comments
Assignees
@p0mvn
Labels
C:x/swap-router F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:task ⚙️ A task belongs to a story
Milestone
CL 2: Module Wiring

Comments

@p0mvn
Copy link
Member

p0mvn commented Oct 18, 2022

Background

As part of milestone 2, we should implement the foundations of the new swap-router module.

See #3042 for more details

Suggested Design

The following keeper methods:

  • SwapExactAmountIn
  • SwapExactAmountOut

Acceptance Criteria

  • follows twap folder structure
  • both message server and keeper methods
@p0mvn p0mvn added this to the CL 2: Module Wiring milestone Oct 18, 2022
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Oct 18, 2022
@p0mvn p0mvn mentioned this issue Oct 18, 2022
Closed
@p0mvn p0mvn added T:task ⚙️ A task belongs to a story F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board labels Oct 18, 2022
@p0mvn p0mvn self-assigned this Oct 19, 2022
@mattverse
Copy link
Member

Closed by #3051

Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Oct 19, 2022
@p0mvn p0mvn reopened this Oct 19, 2022
Repository owner moved this from Done ✅ to In Progress🏃 in Osmosis Chain Development Oct 19, 2022
@p0mvn p0mvn mentioned this issue Oct 19, 2022
Merged
@p0mvn
Copy link
Member Author

p0mvn commented Oct 21, 2022

closed by #3060

@p0mvn p0mvn closed this as completed Oct 21, 2022
Repository owner moved this from In Progress🏃 to Done ✅ in Osmosis Chain Development Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p0mvn p0mvn

Labels
C:x/swap-router F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:task ⚙️ A task belongs to a story
Projects
Osmosis Chain Development
Archived in project
Milestone
CL 2: Module Wiring
Development

No branches or pull requests
2 participants
@p0mvn @mattverse