Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story][CL]: Pool Manager Module #3042

Closed
Tracked by #3014
p0mvn opened this issue Oct 18, 2022 · 4 comments
Closed
Tracked by #3014

[Story][CL]: Pool Manager Module #3042

p0mvn opened this issue Oct 18, 2022 · 4 comments
Labels
C:x/swap-router F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:story A story belongs to an epic

Comments

@p0mvn
Copy link
Member

p0mvn commented Oct 18, 2022

Background

As a user, I would like to have a unified entrypoint for my swaps regardless of the underlying pool implementation so that I don't need to reason about API complexity

#3041 has advocated for a separate module for concentrated liquidity implementation. As a result, we are planning to have 2 entrypoints depending on the underlying pool used:

  • balancer -> entrypoint in gamm
  • stableswap -> entrypoint in gamm
  • concentrated-liquidity` -> entrypoint in ints own module

Suggested Design

Instead of having separate swap messages for each, we should have a unified entrypoint for swaps. Namely, swap-router module that implements the following messages:

  • SwapExactAmountIn
  • SwapExactAmountOut

Depending on the underlying pool type swapped against, the swap is routed to the desired module.

Existing SwapExactAmountIn and SwapExactAmountOut messages are removed from gamm message server. However, any keeper logic is preserved.

Tasks

Acceptance Criteria

  • new module is implemented
  • folder structure similar to twap is used
  • test coverage is maximized
@p0mvn p0mvn added the T:story A story belongs to an epic label Oct 18, 2022
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Oct 18, 2022
@p0mvn p0mvn changed the title [Story]: Swap Router Module [Story][CL]: Swap Router Module Oct 18, 2022
@p0mvn p0mvn added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Oct 19, 2022
@mattverse
Copy link
Member

Closed by #3051

Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Oct 19, 2022
@p0mvn
Copy link
Member Author

p0mvn commented Oct 19, 2022

Reopening since we decided to implemented the swap-router component only (not the pool creation logic)

@p0mvn
Copy link
Member Author

p0mvn commented Jan 12, 2023

Swaprouter was renamed to pool manager, renaming the issue as well

@p0mvn p0mvn changed the title [Story][CL]: Swap Router Module [Story][CL]: Pool Manager Module Jan 12, 2023
@p0mvn
Copy link
Member Author

p0mvn commented Jan 25, 2023

I'm going to move the last issue here to #3030 and close this

@p0mvn p0mvn closed this as completed Jan 25, 2023
@github-project-automation github-project-automation bot moved this from In Progress🏃 to Done ✅ in Osmosis Chain Development Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/swap-router F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:story A story belongs to an epic
Projects
Archived in project
Development

No branches or pull requests

2 participants