Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL][Swap Router Module]: test CreatePool #3236

Closed
p0mvn opened this issue Nov 3, 2022 · 2 comments
Closed

[CL][Swap Router Module]: test CreatePool #3236

p0mvn opened this issue Nov 3, 2022 · 2 comments
Labels
C:x/swap-router F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:tests
Milestone
CL6: Merge to CL ...

Comments

@p0mvn
Copy link
Member

p0mvn commented Nov 3, 2022

Background

We should cover the following test cases:

osmosis/x/swaprouter/creator_test.go

Lines 37 to 39 in 0c2fa2d

// TODO: add stableswap test
// TODO: add concentrated-liquidity rest
// TODO: cover errors and edge cases

Acceptance Criteria

  • tests added
  • all pass
@p0mvn p0mvn added T:tests C:x/swap-router F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board labels Nov 3, 2022
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Nov 3, 2022
This was referenced Nov 3, 2022
Closed
Closed
@hieuvubk
Copy link
Contributor

hieuvubk commented Nov 7, 2022

It's blocked by #3245 . I'm willing to work on this issue after MsgCreateConcentratedPool is implemented.

@czarcas7ic
Copy link
Member

Basic CL test was added as a drive by

Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C:x/swap-router F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:tests
Projects
Osmosis Chain Development
Archived in project
Milestone
CL6: Merge to CL branch to `main`, cr...
Development

No branches or pull requests
3 participants
@p0mvn @czarcas7ic @hieuvubk