Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CL][Swap Router Module]: remove swap messages and tests, connect with swap-router #3064

Closed
p0mvn opened this issue Oct 19, 2022 · 1 comment
Closed

[CL][Swap Router Module]: remove swap messages and tests, connect with swap-router #3064

p0mvn opened this issue Oct 19, 2022 · 1 comment
Assignees
@p0mvn
Labels
C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:task ⚙️ A task belongs to a story
Milestone
CL 3: Swap Routin...

Comments

@p0mvn
Copy link
Member

p0mvn commented Oct 19, 2022

Background

swap-router is the new module that routes swaps. Therefore, we should delete swap messages from gamm. Instead, swap-router will call gamm swap keeper methods directly.

Acceptance Criteria

  • swap messages are deleted from gamm message server
  • connected to swap router
  • tests moved to swap-router
@p0mvn p0mvn added C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board labels Oct 19, 2022
@p0mvn p0mvn moved this to Needs Review 🔍 in Osmosis Chain Development Oct 19, 2022
@p0mvn p0mvn changed the title [CL][GAMM]: remove swap messages and tests, connect with swap-router [CL][Swap Router Module]: remove swap messages and tests, connect with swap-router Oct 19, 2022
@p0mvn p0mvn mentioned this issue Oct 19, 2022
Closed
@p0mvn
Copy link
Member Author

p0mvn commented Oct 19, 2022

blocked by: #3066

@p0mvn p0mvn self-assigned this Oct 20, 2022
@p0mvn p0mvn mentioned this issue Oct 20, 2022
Merged
@p0mvn p0mvn added the T:task ⚙️ A task belongs to a story label Oct 20, 2022
@p0mvn p0mvn closed this as completed Oct 24, 2022
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p0mvn p0mvn

Labels
C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:task ⚙️ A task belongs to a story
Projects
Osmosis Chain Development
Archived in project
Milestone
CL 3: Swap Routing, Generalized Mint ...
Development

No branches or pull requests
1 participant
@p0mvn