Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create testcases for Inactive Pool #3154

Closed
mattverse opened this issue Oct 25, 2022 · 4 comments
Closed

Create testcases for Inactive Pool #3154

mattverse opened this issue Oct 25, 2022 · 4 comments
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@mattverse
Copy link
Member

mattverse commented Oct 25, 2022

Background

Adding a new Interface, namely the traditionalAMMI, we had to remove existing testing that uses mock pool to mock a pool that is inactive and ensure that if pool is inactive, we aren't able to do a swap.

https://github.com/osmosis-labs/osmosis/pull/3152/files#diff-b5cfd36f7b82ca1c172a606b4fd5c6978db0e6f9db3361dea89e2893ab843aeeL276-L327

Suggested Design

We need to update the mock pool package or methods to be able to mock an inactive pool. Right now, the same test would fail, since doing a GetPool operation on a pool created via mock would error.

Acceptance Criteria

  • Doing a GetPool operation on a pool created via mock package does not error
  • We have test on (or we bring back test on) TestInactivePoolFreezeSwaps
  • PRd against concentrated-liquidity-main
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Oct 25, 2022
@p0mvn p0mvn added C:x/concentrated-liquidity F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board and removed Good first issue C:x/concentrated-liquidity labels Oct 26, 2022
@pysel
Copy link
Member

pysel commented Oct 28, 2022

hello is anyone working on it?

@mattverse
Copy link
Member Author

Nope! I don't think so!

@pysel
Copy link
Member

pysel commented Oct 29, 2022

cool, I would like to work on it

@p0mvn
Copy link
Member

p0mvn commented Oct 30, 2022

Please go for it

@pysel pysel removed their assignment Nov 5, 2022
Repository owner moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Archived in project
Development

No branches or pull requests

4 participants