GetPool() works with mock pools / Testcases for Inactive pool
#3181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:x/concentrated-liquidity
C:x/gamm
added 4 commits
November 1, 2022 11:14
|
closing this due to occurred bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(not yet) Closes: #3154
Brief changes:
I brought back the test which was removed in this pr. Did a little refactoring of existing logic to match new TraditionalAMM interface. Also, registered MockPoolI to be of type TraditionalAMM.
What I got when tried to run a test:
An error related to protobuf.
panic: protobuf tag not enough fields in MockPoolI.ctrl. (To reproduce please clone this and runTestInactivePoolFreezeSwapsin game/keeeper/swap_test.go). My guess, well, it happens because we do not have tags of MockPoolI in photo files, but I currently do not know how to solve this.Any help would be really appreciated! Thanks in advance