Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tracking(CL): merge to main #3556

Closed
9 tasks done
p0mvn opened this issue Nov 28, 2022 · 5 comments
Closed
9 tasks done

tracking(CL): merge to main #3556

p0mvn opened this issue Nov 28, 2022 · 5 comments
Assignees
@p0mvn
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:tracking issue ⛰
Milestone
CL6: Merge to CL ...

Comments

@p0mvn
Copy link
Member

p0mvn commented Nov 28, 2022 •
edited
Loading

Background

This issue is for tracking the progress of merging concentrated-liqudiity-main to main.

As we are merging in chunks with the goal of splitting state-break logic from state-compatible, we end up commenting out some functionality and tests.

This issue tracks these areas to make sure nothing is left uncommented

TODOs
@p0mvn p0mvn added T:tracking issue ⛰ F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board labels Nov 28, 2022
@p0mvn p0mvn self-assigned this Nov 28, 2022
@osmo-bot osmo-bot moved this to Needs Review 🔍 in Osmosis Chain Development Nov 28, 2022
This was referenced Nov 28, 2022
Merged
Merged
Merged
Closed
@p0mvn p0mvn mentioned this issue Dec 15, 2022
Merged
@p0mvn
Copy link
Member Author

p0mvn commented Dec 15, 2022 •
edited
Loading

This comment is for tracking PRs merged to concentrated-liqudity-main after the merge has started. Feel free to edit

@p0mvn p0mvn mentioned this issue Dec 15, 2022
Merged
@czarcas7ic
Copy link
Member

czarcas7ic commented Dec 15, 2022 •
edited by p0mvn
Loading

Added concentrated liquidity test to the swaprouter module in the following PR: #3733

See https://github.com/osmosis-labs/osmosis/pull/3733/files/0083c205e4d359aaaa2129f2a160087a02571524#r1049147785

Also added the concentratedLiquidityKeeper type to the router_test.go file as a variable

UPDATE: this is addressed

This was referenced Dec 16, 2022
Merged
Merged
@p0mvn
Copy link
Member Author

p0mvn commented Dec 28, 2022 •
edited
Loading

CL module merge removals that need to be re-added:

Tests:

Codec removals:

This was referenced Dec 28, 2022
Merged
Merged
Merged
@p0mvn
Copy link
Member Author

p0mvn commented Jan 3, 2023 •
edited
Loading

Using this comment as a sanity check on what TODOs have been complete:

@p0mvn p0mvn mentioned this issue Jan 3, 2023
Merged
8 tasks
@p0mvn
Copy link
Member Author

p0mvn commented Jan 3, 2023

All TODOs here have been addressed. The only remaining one is kept in code as TODO since it is non-blocking:

@p0mvn p0mvn closed this as completed Jan 3, 2023
@github-project-automation github-project-automation bot moved this from Needs Review 🔍 to Done ✅ in Osmosis Chain Development Jan 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@p0mvn p0mvn

Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board T:tracking issue ⛰
Projects
Osmosis Chain Development
Archived in project
Milestone
CL6: Merge to CL branch to `main`, cr...
Development

No branches or pull requests
2 participants
@p0mvn @czarcas7ic