refactor(x/gamm): remove CreatePool and pool id index boilerplate in gamm (merge) #3739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:app-wiring
p0mvn
commented
Dec 15, 2022
| @@ -337,17 +350,6 @@ func (appKeepers *AppKeepers) InitNormalKeepers( | |||
| ) | |||
| appKeepers.TokenFactoryKeeper = &tokenFactoryKeeper | |||
|
|
|||
| appKeepers.SwapRouterKeeper = swaprouter.NewKeeper( | |||
There was a problem hiding this comment.
Note: Moved up top to be consistent with CL main. It is also convenient for initializing pool incentives keeper close to a similar logic in gamm
p0mvn
commented
Dec 16, 2022
| @@ -109,12 +109,12 @@ func (q Querier) Pools( | |||
| }, nil | |||
| } | |||
|
|
|||
| // NumPools returns total number of pools. | |||
| // TODO: mark deprecated and move to swaprouter. | |||
p0mvn
changed the title
p0mvn
changed the title
p0mvn
commented
Dec 16, 2022
|
Going to merge with 1 approval once CI passes. This has been QAed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
Currently, we update the pool id index in both
x/gammandx/swaprouter. Since the goal is to fully migrate the index tox/swaproter, we start to remove any references it the oldx/gammindex.We still need to keep the state entry in
x/gamm. However, every method, function or query, utilizing it can be refactored to either swithc to queryingx/swaprouterindex or be removed entirely.Brief Changelog
As a result, of sunsetting the index in
x/gamm, the folllowing changes have been made:CreatePoolmethod fromx/gamm. Its callers instead useCreatePoolinx/swaprouter.GetNextPoolIdAndIncrementfunction inx/gammsince the updates to the index should not happen anymoreTesting and Verifying
This change is already covered by existing tests
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no