Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story][CL]: Invariant testing for concentrated liquidity #4047

Closed
mattverse opened this issue Jan 17, 2023 · 3 comments
Closed

[Story][CL]: Invariant testing for concentrated liquidity #4047

mattverse opened this issue Jan 17, 2023 · 3 comments
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board

Comments

@mattverse
Copy link
Member

mattverse commented Jan 17, 2023

Background

As an engineer, I want to have the certainty that different traits of Concentrated Liquidity always remain true, in other words, have invariants testings to assure safeness

Acceptance Criteria

Investigate and implement the following invariants testings for concentrated liquidity


  • Swap fee accumulator should never decrease by design
@mattverse mattverse added the F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board label Jan 17, 2023
@github-project-automation github-project-automation bot moved this to Needs Review 🔍 in Osmosis Chain Development Jan 17, 2023
@p0mvn
Copy link
Member

p0mvn commented Jan 19, 2023

I would like to also think more about invariants related to swaps and collecting fees.

I don't have any specific suggestions at the moment. However, the general idea is to have some invariants to make sure that it is impossible to overclaim fees

@mattverse
Copy link
Member Author

Cool! Thanks for the suggestion! Would think about how to make a good testing from the fees!

@p0mvn
Copy link
Member

p0mvn commented Jan 30, 2023

Hi @mattverse . Seeing that there are 2 remaining items on the list here. I'm assuming these are blocked on swap fee PRs?

If so, is it possible to break down the remaining work into issues please to have a sense of what's remaining on the sprint board?

@p0mvn p0mvn closed this as completed Mar 2, 2023
@github-project-automation github-project-automation bot moved this from Needs Triage 🔍 to Done ✅ in Osmosis Chain Development Mar 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
F: concentrated-liquidity Tracking the development of concentrated liquidity feature to improve filtering on the project board
Projects
Archived in project
Development

No branches or pull requests

2 participants