(CL test): Add tests for inverse relationship testing between TickToSqrtPrice and PriceToTick #4060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattverse
reviewed
Jan 18, 2023
Comment on lines
+260
to
+277
| "50000 to tick with -4 k at price one": { | ||
| price: sdk.NewDec(50000), | ||
| exponentAtPriceOne: sdk.NewInt(-4), | ||
| tickExpected: "400000", | ||
| }, | ||
| "5.01 to tick with -2 k at price one": { | ||
| price: sdk.MustNewDecFromStr("5.01"), | ||
| exponentAtPriceOne: sdk.NewInt(-2), | ||
| tickExpected: "401", | ||
| }, | ||
| "50000.01 to tick with -6 k at price one": { | ||
| price: sdk.MustNewDecFromStr("50000.01"), | ||
| exponentAtPriceOne: sdk.NewInt(-6), | ||
| tickExpected: "40000001", | ||
| }, | ||
| "0.090000889 to tick with -8 k at price one": { | ||
| price: sdk.MustNewDecFromStr("0.090000889"), | ||
| exponentAtPriceOne: sdk.NewInt(-8), |
There was a problem hiding this comment.
Just curious, are these chose arbitrarily?
There was a problem hiding this comment.
It's from test cases of TestPriceToTick function, I originally thought about creating my own test cases, but I think it's better to reuse it with the code have verified
osmosis/x/concentrated-liquidity/internal/math/tick_test.go
Lines 170 to 189 in 07de0b4
ThanhNhann
changed the title
mattverse
approved these changes
Jan 18, 2023
Comment on lines
+260
to
+277
| "50000 to tick with -4 k at price one": { | ||
| price: sdk.NewDec(50000), | ||
| exponentAtPriceOne: sdk.NewInt(-4), | ||
| tickExpected: "400000", | ||
| }, | ||
| "5.01 to tick with -2 k at price one": { | ||
| price: sdk.MustNewDecFromStr("5.01"), | ||
| exponentAtPriceOne: sdk.NewInt(-2), | ||
| tickExpected: "401", | ||
| }, | ||
| "50000.01 to tick with -6 k at price one": { | ||
| price: sdk.MustNewDecFromStr("50000.01"), | ||
| exponentAtPriceOne: sdk.NewInt(-6), | ||
| tickExpected: "40000001", | ||
| }, | ||
| "0.090000889 to tick with -8 k at price one": { | ||
| price: sdk.MustNewDecFromStr("0.090000889"), | ||
| exponentAtPriceOne: sdk.NewInt(-8), |
mattverse
added
the
V:state/compatible/no_backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3993
What is the purpose of the change
Add tests for inverse relationship testing between
TickToSqrtPriceandPriceToTickBrief Changelog
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)x/<module>/spec/) / Osmosis docs repo / not documented)