-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(CL Test): Add tests for inverse relationship testing between TickToPrice
and PriceToTick
#3993
Comments
Marked this as "Help wanted" since this test is not on the critical path. |
Hi could I work with it @mattverse @p0mvn |
@hieuvubk yes please! |
Hey @mattverse, I checked the code again and see that the |
I see that this #4003 had changed |
@ThanhNhann Yes in this case, lets test inverse relationship between TicksToSqrtPrice and PriceToTick. Im assuming that there would be a little bit of margin of error that would have to be considered when designing the test cases |
Thank @mattverse, I have updated the tests |
Background
Upon implementing #3874 tick spacing), we have re-implemented
TickToPrice
function andPriceToTick
function.As we test the inverse relationship for joinPool and exitPool in the gamm module, it would be best if we could add a test for ensuring the inverse calculation between the two methods.
Acceptance Criteria
TickToPrice
and then using the returned value callingPriceToTick
and then checking if we get the same test vectors that we used as inputsThe text was updated successfully, but these errors were encountered: