Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V17: Scoping Issue #5191

Closed
21 of 24 tasks
p0mvn opened this issue May 16, 2023 · 5 comments
Closed
21 of 24 tasks

V17: Scoping Issue #5191

p0mvn opened this issue May 16, 2023 · 5 comments

Comments

@p0mvn
Copy link
Member

p0mvn commented May 16, 2023

Background

Tentative plan for the v17 scope. Each effort is to have a design document created. Upon reviewing and accepting the design, the final decision about v17 inclusion will be made.

Note: hackmd with post-CL plans: https://hackmd.io/FOlDt6H7QlqyabBYhZVxMQ

  • Async ICQ (Dev/Nicholas)
  • Full power token factory (Matt)
  • Protorev (Skip)
  • Msg to break lock, swap to osmo, then stake (Matt)

In-Scope

Tasks

Preview Give feedback
  1. C:gRPC T:dev-UX
    mattverse
  2. czarcas7ic
  3. NotJeremyLiu stackman27
  4. F: concentrated-liquidity
    czarcas7ic
  5. stackman27
  6. F: concentrated-liquidity T:bug 🐛
    czarcas7ic p0mvn
  7. C:app-wiring C:docs V:state/breaking
    nicolaslara p0mvn
  8. stackman27
  9. C:CLI C:x/concentrated-liquidity C:x/poolmanager V:state/breaking
    czarcas7ic
  10. iboss-ptk mattverse
  11. stackman27
  12. czarcas7ic
  13. mattverse
  14. C:x/lockup Stale
  15. C:docs C:x/superfluid Stale V:state/breaking
  16. czarcas7ic mattverse
  17. C:x/tokenfactory V:state/breaking

To Be Decided if included in v17

Tasks

Preview Give feedback
  1. mattverse

Not Release Blocking

Tasks

Preview Give feedback
  1. ValarDragon

Concurrent To v17

Efforts being pursued concurrently but independently of v17 release

Tasks

Preview Give feedback
  1. nicolaslara
  2. mattverse niccoloraspa
  3. 10 of 15
    F: Crosschain Swaps T:epic ⛰
    czarcas7ic nicolaslara
@faddat
Copy link
Member

faddat commented May 17, 2023

I think that if v17 is on sdk 48, ibc will be at v8. Kind of a nit, but I think that'll be the case.

Can you run me through POB and volume based incentives?

Generally, we've been advising that chain upgrades to a new sdk version do not add features. How would you feel about doing this as a v17, then a v18 shortly after, with POB and volume based incentive splitting?

Also please note that I'm adding stuff to the issue above, lmk if that's alright.

@faddat
Copy link
Member

faddat commented Jun 17, 2023

Okay so I figured out that POB is the protocol owned builder from Skip and that sounds awesome, I'm currently upgrading IBC to SDK 50 and I guess I'd like to ask @ValarDragon If his stance has changed on using dependency injection in osmosis, not using it is really looking pretty baroque.

@p0mvn
Copy link
Member Author

p0mvn commented Jul 3, 2023

I think that if v17 is on sdk 48, ibc will be at v8. Kind of a nit, but I think that'll be the case.

Can you run me through POB and volume based incentives?

Generally, we've been advising that chain upgrades to a new sdk version do not add features. How would you feel about doing this as a v17, then a v18 shortly after, with POB and volume based incentive splitting?

Also please note that I'm adding stuff to the issue above, lmk if that's alright.

Sorry for the late reply.

I think that if v17 is on sdk 48, ibc will be at v8

Sounds great, thanks for the info. We haven't started investigating yet as we've been busy with CL. Will look more into it in a few weeks.

How would you feel about doing this as a v17, then a v18 shortly after, with POB and volume based incentive splitting?

Generally, we are supportive of smaller releases at a faster cadence. This issue's main goal is to track the next immediate priorities and what we want in v17. Before we fully converge on the scope, a design document will be written for each item identified here. Once the design documents shed light on the overall scope, we will make a decision on what the final v17 will look like.

Can you run me through POB and volume based incentives?

Looks like POB is already resolved. Volume-based incentives is a system to incentivize a denom pair assuming that there are 2 pools for the same pair such as classic and CL pool. Then, the distribution to each of the pools will be dynamically split based on volume.

Also please note that I'm adding stuff to the issue above, lmk if that's alright.

Let's not add lints here please and use this issue for tracking release blocking items instead.
We can get in the lint improvements but they don't necessarily have to block the v17 release

@faddat
Copy link
Member

faddat commented Jul 8, 2023

@p0mvn great point about the lints.

I try and do them before upgrades to make the upgrade easier becasue the upgrade tends to break a lot of things, but you're right they absolutely shouldn't block a release.

Want to have a call sometime next week in order to figure out what the unfork should look like?

@faddat
Copy link
Member

faddat commented Jul 10, 2023

@p0mvn -- here's an update of ibc-go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants