Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Estimate Swap queries via grpc gateway #5446

Closed
Tracked by #5191
mattverse opened this issue Jun 7, 2023 · 0 comments · Fixed by #5810
Closed
Tracked by #5191

Support Estimate Swap queries via grpc gateway #5446

mattverse opened this issue Jun 7, 2023 · 0 comments · Fixed by #5810
Assignees
Labels
C:gRPC Issues and PRs related to the gRPC service and HTTP gateway. T:dev-UX

Comments

@mattverse
Copy link
Member

Background

GRPC Gateway does not support queries on repeated structs in proto, thus all estimate swaps are not supported in GRPC gateway as of right now, only through GRPC.

Suggested Design

Suggested design is that we leave the current estimate queries as is, since

  1. Changing this would be API breaking
  2. Using repeated structs in GRPC is a better option for code sanity.

Instead what we can do is create a secondary query for grpc gateway, where we do not use repeated structs. We can do this by using repeated primitive types as fields in the request proto struct and then mapping them by index internally to create the needed repeated struct.

Acceptance Criteria

  • New Query to support estimate swap query for grpc gateway has been added and tested
@mattverse mattverse added C:gRPC Issues and PRs related to the gRPC service and HTTP gateway. T:dev-UX labels Jun 7, 2023
@mattverse mattverse self-assigned this Jun 26, 2023
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Osmosis Chain Development Jun 26, 2023
@p0mvn p0mvn moved this from Needs Triage 🔍 to Todo 🕒 in Osmosis Chain Development Jun 26, 2023
@czarcas7ic czarcas7ic moved this from Todo 🕒 to Needs PR Review in Osmosis Chain Development Jul 26, 2023
@github-project-automation github-project-automation bot moved this from Needs PR Review to Done ✅ in Osmosis Chain Development Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:gRPC Issues and PRs related to the gRPC service and HTTP gateway. T:dev-UX
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant