You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
GRPC Gateway does not support queries on repeated structs in proto, thus all estimate swaps are not supported in GRPC gateway as of right now, only through GRPC.
Suggested Design
Suggested design is that we leave the current estimate queries as is, since
Changing this would be API breaking
Using repeated structs in GRPC is a better option for code sanity.
Instead what we can do is create a secondary query for grpc gateway, where we do not use repeated structs. We can do this by using repeated primitive types as fields in the request proto struct and then mapping them by index internally to create the needed repeated struct.
Acceptance Criteria
New Query to support estimate swap query for grpc gateway has been added and tested
The text was updated successfully, but these errors were encountered:
Background
GRPC Gateway does not support queries on repeated structs in proto, thus all estimate swaps are not supported in GRPC gateway as of right now, only through GRPC.
Suggested Design
Suggested design is that we leave the current estimate queries as is, since
Instead what we can do is create a secondary query for grpc gateway, where we do not use repeated structs. We can do this by using repeated primitive types as fields in the request proto struct and then mapping them by index internally to create the needed repeated struct.
Acceptance Criteria
The text was updated successfully, but these errors were encountered: