Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make app.go boilerplate methods go into their own file #713

Closed
Tracked by #671
ValarDragon opened this issue Jan 4, 2022 · 0 comments · Fixed by #862
Closed
Tracked by #671

Make app.go boilerplate methods go into their own file #713

ValarDragon opened this issue Jan 4, 2022 · 0 comments · Fixed by #862
Labels
backburner Good first issue

Comments

@ValarDragon
Copy link
Member

ValarDragon commented Jan 4, 2022 •
edited
Loading

There are many boilerplate methods in app.go, they should be moved to their own boilerplate.go files.
@ValarDragon ValarDragon mentioned this issue Jan 4, 2022
Closed
3 tasks
@ValarDragon ValarDragon changed the title Move all boilerplate methods (line 730 onwards) into its own file. Make app.go boilerplate methods go into their own file Jan 4, 2022
@voluntatis-summ voluntatis-summ mentioned this issue Feb 14, 2022
Merged
4 tasks
ValarDragon pushed a commit that referenced this issue Feb 27, 2022
@voluntatis-summ
[#713] app boilerplate to files (#862)
8d50ef5 
* create app/modules.go

* add AppKeepers struct
Repository owner moved this from 🕒 Todo to ✅ Done in Osmosis Chain Development Feb 27, 2022
mergify bot pushed a commit that referenced this issue Feb 27, 2022
@voluntatis-summ
[#713] app boilerplate to files (#862)
22e4a91 
* create app/modules.go

* add AppKeepers struct

(cherry picked from commit 8d50ef5)
ValarDragon pushed a commit that referenced this issue Mar 1, 2022
@mergify @voluntatis-summ
[#713] app boilerplate to files (#862) (#997)
8ce7b0d 
* create app/modules.go

* add AppKeepers struct

(cherry picked from commit 8d50ef5)

Co-authored-by: voluntatis_summ <93878971+voluntatis-summ@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backburner Good first issue
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#713] app boilerplate to files voluntatis-summ/osmosis
1 participant
@ValarDragon