Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eugen/cherry pick superfluid test scaffolding updates #1052

Merged

Conversation

antstalepresh
Copy link
Contributor

Closes: #XXX

Description


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2022

Codecov Report

Merging #1052 (d911b90) into main (bff6f64) will increase coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1052      +/-   ##
==========================================
+ Coverage   20.60%   20.69%   +0.08%     
==========================================
  Files         193      193              
  Lines       25237    25258      +21     
==========================================
+ Hits         5199     5226      +27     
+ Misses      19084    19078       -6     
  Partials      954      954              
Impacted Files Coverage Δ
x/superfluid/keeper/stake.go 53.48% <0.00%> (-0.63%) ⬇️
x/lockup/keeper/lock.go 54.46% <0.00%> (+0.85%) ⬆️
x/lockup/client/cli/tx.go 64.70% <0.00%> (+1.69%) ⬆️
x/superfluid/keeper/hooks.go 72.22% <0.00%> (+5.55%) ⬆️
x/superfluid/keeper/epoch.go 67.92% <0.00%> (+5.66%) ⬆️
x/lockup/client/cli/flags.go 61.53% <0.00%> (+11.53%) ⬆️
x/superfluid/keeper/superfluid_asset.go 84.61% <0.00%> (+53.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b27b5b2...d911b90. Read the comment docs.

Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change for code sanity requested, otherwise LGTM!

x/superfluid/keeper/stake_test.go Outdated Show resolved Hide resolved
Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
@antstalepresh
Copy link
Contributor Author

Small change for code sanity requested, otherwise LGTM!

Your suggestion is merged and checked the test pass

@ValarDragon ValarDragon merged commit f375c5a into main Mar 8, 2022
@ValarDragon ValarDragon deleted the eugen/cherry-pick-superfluid-test-scaffolding-updates branch March 8, 2022 18:03
@mattverse mattverse added the A:backport/v7.x Do not use. backport patches to v7.x branch label Mar 14, 2022
mergify bot pushed a commit that referenced this pull request Mar 14, 2022
* add utility for SetupGammPoolsAndSuperfluidAssets

* remove hardcoded gamm pool denoms

* fix for main branch ctx => Ctx, app => App in tests

* Update x/superfluid/keeper/stake_test.go

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
(cherry picked from commit f375c5a)
mattverse pushed a commit that referenced this pull request Mar 14, 2022
* add utility for SetupGammPoolsAndSuperfluidAssets

* remove hardcoded gamm pool denoms

* fix for main branch ctx => Ctx, app => App in tests

* Update x/superfluid/keeper/stake_test.go

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
(cherry picked from commit f375c5a)

Co-authored-by: antstalepresh <36045227+antstalepresh@users.noreply.github.com>
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v7.x Do not use. backport patches to v7.x branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants