Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superfluid Misc: Improve grpc_query #1084

Merged
merged 2 commits into from
Mar 14, 2022
Merged

Conversation

mattverse
Copy link
Member

Closes: #1080

Description

This PR introduces the following improvements for grpc_query in the superfluid module.

  • Fix bug where non-existent connected-intermediary-account would still return an address
  • Fix bug for total_supefluid_delegations

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@mattverse mattverse requested a review from ValarDragon March 14, 2022 03:08
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2022

Codecov Report

Merging #1084 (85ed361) into main (f897502) will increase coverage by 0.19%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1084      +/-   ##
==========================================
+ Coverage   20.64%   20.84%   +0.19%     
==========================================
  Files         193      194       +1     
  Lines       25270    25331      +61     
==========================================
+ Hits         5218     5280      +62     
+ Misses      19096    19092       -4     
- Partials      956      959       +3     
Impacted Files Coverage Δ
x/superfluid/keeper/grpc_query.go 56.28% <100.00%> (+9.73%) ⬆️
x/superfluid/keeper/hooks.go 66.66% <0.00%> (-5.56%) ⬇️
x/claim/keeper/hooks.go 25.92% <0.00%> (-2.08%) ⬇️
x/superfluid/keeper/invariants.go 54.05% <0.00%> (ø)
x/superfluid/keeper/intermediary_account.go 88.46% <0.00%> (+1.69%) ⬆️
x/superfluid/keeper/stake.go 58.13% <0.00%> (+4.65%) ⬆️
x/superfluid/keeper/keeper.go 100.00% <0.00%> (+6.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f897502...85ed361. Read the comment docs.

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes here!

@ValarDragon ValarDragon added the A:backport/v7.x Do not use. backport patches to v7.x branch label Mar 14, 2022
@ValarDragon ValarDragon merged commit 052bc20 into main Mar 14, 2022
@ValarDragon ValarDragon deleted the mattverse/superfluid-fix-query branch March 14, 2022 03:32
mergify bot pushed a commit that referenced this pull request Mar 14, 2022
* Fix Query for empty connected intermediary account

* Improve superfluid grpc-query

(cherry picked from commit 052bc20)

# Conflicts:
#	x/superfluid/keeper/grpc_query_test.go
mattverse added a commit that referenced this pull request Mar 14, 2022
* Superfluid Misc: Improve grpc_query (#1084)

* Fix Query for empty connected intermediary account

* Improve superfluid grpc-query

(cherry picked from commit 052bc20)

# Conflicts:
#	x/superfluid/keeper/grpc_query_test.go

* Fix merge

Co-authored-by: Matt, Park <45252226+mattverse@users.noreply.github.com>
Co-authored-by: mattverse <mattpark1028@gmail.com>
@github-actions github-actions bot mentioned this pull request May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:backport/v7.x Do not use. backport patches to v7.x branch
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants