Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GH Action to push to Docker Registry #1105

Merged
merged 2 commits into from
Mar 16, 2022
Merged

Add GH Action to push to Docker Registry #1105

merged 2 commits into from
Mar 16, 2022

Conversation

niccoloraspa
Copy link
Member

@niccoloraspa niccoloraspa commented Mar 16, 2022

Description

This PR adds a GitHub Action to automatically build and push a new osmosis docker image on every new tag release.

When a new tag v7.0.5 is released:

  • osmolabs/osmosis:7.0.5 is pushed
  • osmolabs/osmosis:latest is updated
  • osmolabs/osmosis:7.0 is created/updated
  • osmolabs/osmosis:7 is created/updated

I have dropped the v from the docker tag, which is the recommend approach. So:

🚫 docker pull osmolabs/osmosis:v7.0.5
docker pull osmolabs/osmosis:7.0.5

I will keep both in the registry for now so people can still pull previous images without disruption.
Moving forward only tags without the v will be pushed.


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

@codecov-commenter
Copy link

codecov-commenter commented Mar 16, 2022

Codecov Report

Merging #1105 (f02c282) into main (72dee1f) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1105   +/-   ##
=======================================
  Coverage   20.94%   20.94%           
=======================================
  Files         199      199           
  Lines       25429    25429           
=======================================
  Hits         5326     5326           
  Misses      19140    19140           
  Partials      963      963           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72dee1f...f02c282. Read the comment docs.

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!! This is really exciting, thanks for automating this step!

@ValarDragon ValarDragon merged commit a8b4eb8 into osmosis-labs:main Mar 16, 2022
@daniel-farina
Copy link
Contributor

amazing!!

@github-actions github-actions bot mentioned this pull request Mar 1, 2024
@github-actions github-actions bot mentioned this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants