Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update state sync scripts #1234

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Update state sync scripts #1234

merged 1 commit into from
Apr 12, 2022

Conversation

faddat
Copy link
Member

@faddat faddat commented Apr 12, 2022

Description

NB: Previously, osmosis would apply all snapshots, then crash.

Currently, osmosis applies all snapshots, and stays live. Because it stays live, these scripts don't work correctly.

I have a machine doing a rocksdb sync now, and hope to prune that but nothing makes tiny snapshots like statesync.

Pursuant to #695


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

NB: Previously, osmosis would apply all snapshots, then crash.

Currently, osmosis applies all snapshots, and stays live.  Because it stays live, these scripts don't work correctly.

I have a machine doing a rocksdb sync now, and hope to prune that but nothing makes tiny like statesyc.
@codecov-commenter
Copy link

Codecov Report

Merging #1234 (7232b86) into main (20cfa05) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1234   +/-   ##
=======================================
  Coverage   20.96%   20.96%           
=======================================
  Files         196      196           
  Lines       25337    25337           
=======================================
  Hits         5312     5312           
  Misses      19066    19066           
  Partials      959      959           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20cfa05...7232b86. Read the comment docs.

@faddat faddat mentioned this pull request Apr 12, 2022
8 tasks
Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the script fixes!

@ValarDragon ValarDragon merged commit 204d73d into main Apr 12, 2022
@ValarDragon ValarDragon deleted the faddat/statesync-update branch April 12, 2022 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants