fix: release build scripts #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1286 +/- ##
==========================================
- Coverage 20.90% 20.14% -0.76%
==========================================
Files 196 203 +7
Lines 25425 26824 +1399
==========================================
+ Hits 5316 5405 +89
- Misses 19118 20412 +1294
- Partials 991 1007 +16
Continue to review full report at Codecov.
|
p0mvn
force-pushed
the
roman/fix-release-builder
branch
from
a3bf439 to
d4f95c0
Compare
ValarDragon
reviewed
Apr 18, 2022
Makefile
Outdated
| @@ -85,7 +88,7 @@ all: install lint test | |||
|
|
|||
| BUILD_TARGETS := build install | |||
|
|
|||
| build: BUILD_ARGS=-o $(BUILDDIR)/ | |||
| build: BUILD_ARGS=-o $(BUILDDIR)/ | |||
There was a problem hiding this comment.
is this leading space right? I thought make file commands have to have no leading spaces for the definition
There was a problem hiding this comment.
This is a typo that is fixed now. Thanks for catching that
It worked locally for me. I remember we were having issues in CI when having 4 spaces instead of tabs. That seems to be breaking things
ValarDragon
approved these changes
Apr 19, 2022
Just had a call with @nikever , and he helped me to make the builder logic work with a non-root user in the The problem building as a root is that if an end-user runs our binary as a non-root, they might get some permission errors. I'll make this PR a draft for now to integrate some final changes related to non-root |
|
This is ready now |
mergify bot
pushed a commit
that referenced
this pull request
Apr 28, 2022
* update all builders * rbuilder images are prefixed by osmolabs * update makefile * use root instead of builder user and other minor changes * correct lib path in Makefile * LINK_STATICALLY in Makefile * docs for builder * update README * changelog entry * remove make clean from .build.sh * improve readme * remove spurious whitespace in Makefile * fix formatting for build-reproducible * update cosmwasm path in makefile * copy from /home/builder in build-reproducible * change wasm file pemissions to non-root (cherry picked from commit 2029415) # Conflicts: # CHANGELOG.md
czarcas7ic
pushed a commit
that referenced
this pull request
Apr 28, 2022
* update all builders * rbuilder images are prefixed by osmolabs * update makefile * use root instead of builder user and other minor changes * correct lib path in Makefile * LINK_STATICALLY in Makefile * docs for builder * update README * changelog entry * remove make clean from .build.sh * improve readme * remove spurious whitespace in Makefile * fix formatting for build-reproducible * update cosmwasm path in makefile * copy from /home/builder in build-reproducible * change wasm file pemissions to non-root
czarcas7ic
added a commit
that referenced
this pull request
Apr 28, 2022
* fix: release build scripts (#1286) * update all builders * rbuilder images are prefixed by osmolabs * update makefile * use root instead of builder user and other minor changes * correct lib path in Makefile * LINK_STATICALLY in Makefile * docs for builder * update README * changelog entry * remove make clean from .build.sh * improve readme * remove spurious whitespace in Makefile * fix formatting for build-reproducible * update cosmwasm path in makefile * copy from /home/builder in build-reproducible * change wasm file pemissions to non-root (cherry picked from commit 2029415) # Conflicts: # CHANGELOG.md * fix: release build scripts (#1286) * update all builders * rbuilder images are prefixed by osmolabs * update makefile * use root instead of builder user and other minor changes * correct lib path in Makefile * LINK_STATICALLY in Makefile * docs for builder * update README * changelog entry * remove make clean from .build.sh * improve readme * remove spurious whitespace in Makefile * fix formatting for build-reproducible * update cosmwasm path in makefile * copy from /home/builder in build-reproducible * change wasm file pemissions to non-root * fix changelog Co-authored-by: Roman <34196718+p0mvn@users.noreply.github.com> Co-authored-by: Adam Tucker <adamleetucker@outlook.com>
This was referenced Jun 1, 2022
4 tasks
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #1284
What is the purpose of the change
This change fixes our
make build-reproducibleMakefile step to generate release binaries. As described in the issue #1284, our current binaries do not have cosm wasm dependencies correctly installed. Wasmvm binaries need to be statically linked.On initial investigation, I observed that our
rbuilderis broken when built locally. The version from docker hub that is used by default when local version is not available has not been updated in around a year and does not work with themainbranch of our repository.As a result, our
rbuilderwas fixed in this PR by referencing the updated version here: https://github.com/tendermint/images/tree/master/rbuilderAdditionally, it does not make sense to rely on the cosmoshub image (
cosmossdk/rbuilder:latest). That is not built by our team.I propose to push the final result of the
rbuilderin this PR to our Dockerhub (i.eosmolabs/rbuilder) CC: @nikeverBrief change log
make build-reproducibleand all related scripts by referencing: https://github.com/tendermint/images/tree/master/rbuilderPR Formatting
Testing and Verifying
Built the binary with
make built-reproducibleon main branch and successfully ran it without getting the error described in #1284:Documentation and Release Note
Unreleasedsection inCHANGELOG.md? yescontrib/images/README.md