-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaling factor governor #1499
Scaling factor governor #1499
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1499 +/- ##
==========================================
- Coverage 19.66% 19.46% -0.21%
==========================================
Files 241 241
Lines 31837 32181 +344
==========================================
+ Hits 6261 6263 +2
- Misses 24424 24766 +342
Partials 1152 1152
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks so much for adding this!
Want to just add a test that ensures the factors do get updated in state, then we can merge it in?
Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com>
yep ! I'll add that test. Thanks for reviewing ! |
I added test but commented it out because stableswap still disable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR! Nit for the ones I left reviews on the commented ones, seems that we still need to add codec.go
before merging though
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes: #1460
What is the purpose of the change
(E.g.: This pull request improves documation of area A by adding ....
Brief Changelog
(for example:)
Testing and Verifying
(Please pick one of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation and Release Note
Unreleased
section inCHANGELOG.md
? (yes / no)x/<module>/spec/
) / Osmosis docs repo / not documented)