Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Stableswap #1523

Merged
merged 3 commits into from
May 17, 2022
Merged

Disable Stableswap #1523

merged 3 commits into from
May 17, 2022

Conversation

mattverse
Copy link
Member

Closes: #1503

What is the purpose of the change

The upcoming V9 upgrade should be including the gamm generalization, but not stable swap implementations.
This PR removes(comments out) stable swap inplementation and existing stableswap calls, which was to my surprise only present in msg_sever.go and module.go.

Brief Changelog

  • Remove stableswap implementation from gamm module

Testing and Verifying

This change is a trivial rework / code cleanup without any test coverage.

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? no
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@mattverse mattverse requested a review from a team May 17, 2022 10:48
@github-actions github-actions bot added the C:x/gamm Changes, features and bugs related to the gamm module. label May 17, 2022
@mattverse mattverse mentioned this pull request May 17, 2022
14 tasks
@codecov-commenter
Copy link

codecov-commenter commented May 17, 2022

Codecov Report

Merging #1523 (597fab5) into main (f149135) will increase coverage by 0.03%.
The diff coverage is 36.04%.

@@            Coverage Diff             @@
##             main    #1523      +/-   ##
==========================================
+ Coverage   19.50%   19.54%   +0.03%     
==========================================
  Files         231      235       +4     
  Lines       31527    31598      +71     
==========================================
+ Hits         6150     6176      +26     
- Misses      24251    24293      +42     
- Partials     1126     1129       +3     
Impacted Files Coverage Δ
x/gamm/keeper/msg_server.go 2.81% <ø> (-1.24%) ⬇️
x/gamm/module.go 64.10% <ø> (-2.57%) ⬇️
x/gamm/pool-models/balancer/amm.go 25.37% <0.00%> (+3.76%) ⬆️
x/gamm/pool-models/stableswap/amm.go 44.20% <0.00%> (-7.06%) ⬇️
x/gamm/pool-models/stableswap/pool.go 0.00% <0.00%> (ø)
osmoutils/binary_search.go 79.48% <79.48%> (ø)
osmoutils/cli_helpers.go 0.00% <0.00%> (ø)
osmoutils/cache_ctx.go 0.00% <0.00%> (ø)
osmoutils/dec_helper.go 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f304ed8...597fab5. Read the comment docs.

Copy link
Contributor

@alexanderbez alexanderbez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. If stableswap was its own module, you wouldn't have to comment anything out -- you just exclude it from the modules list in app.go.

cc @ValarDragon

@mergify mergify bot merged commit d3af599 into main May 17, 2022
@mergify mergify bot deleted the mattverse/disable-stableswap branch May 17, 2022 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge C:x/gamm Changes, features and bugs related to the gamm module.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[v9 RC Blocker] Disable Stableswap
5 participants