Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Token factory documentation #1545

Merged
merged 4 commits into from
May 25, 2022
Merged

Conversation

mattverse
Copy link
Member

Closes: #XXX

What is the purpose of the change

Adding documentation of token factory: Leaving this as a draft since I've only added a message section for now, any ideas on documentation we can add here is welcomed

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? (yes / no)
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? (yes / no)
  • How is the feature or change documented? (not applicable / specification (x/<module>/spec/) / Osmosis docs repo / not documented)

@mattverse mattverse requested a review from a team May 19, 2022 15:56
@mattverse mattverse marked this pull request as draft May 19, 2022 15:56
@codecov-commenter
Copy link

codecov-commenter commented May 19, 2022

Codecov Report

Merging #1545 (90db905) into main (82e58f8) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1545   +/-   ##
=======================================
  Coverage   19.46%   19.46%           
=======================================
  Files         241      241           
  Lines       32183    32183           
=======================================
  Hits         6264     6264           
  Misses      24767    24767           
  Partials     1152     1152           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82e58f8...90db905. Read the comment docs.

@stackman27
Copy link
Contributor

What feeTokens would these new tokens have? Is that worth documenting?

Also, are we not keeping track of x/tokenFactory progress in #1029?

@mattverse
Copy link
Member Author

Token factory is a module that allows creating, minting and burning of a new token. That being said, token factory module doesnt add any new tokens by itself, but would be rather added by the users using the token factory

@ValarDragon
Copy link
Member

Alright if I merge this now, to not have this blocked on further updates!

@daniel-farina
Copy link
Contributor

I think we should merge this, it can be updated/improved later but we need it.

@ValarDragon ValarDragon marked this pull request as ready for review May 24, 2022 22:21
@ValarDragon ValarDragon mentioned this pull request May 25, 2022
@ValarDragon ValarDragon merged commit ddb3157 into main May 25, 2022
@ValarDragon ValarDragon deleted the mattverse/tokenfactory-documentation branch May 25, 2022 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants