modifications for mint amount distribution #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ValarDragon
reviewed
May 12, 2021
x/mint/keeper/keeper_test.go
Outdated
| coin = mintKeeper.GetPoolAllocatableAsset(suite.ctx) | ||
| suite.Equal("316258stake", coin.String()) | ||
| coin = mintKeeper.GetPoolAllocatableAsset(suite.ctx, sdk.NewCoins(sdk.NewCoin("stake", sdk.NewInt(1481290)), sdk.NewCoin("test", sdk.NewInt(12389190)))) | ||
| suite.Equal("296258stake", coin.String()) |
There was a problem hiding this comment.
Can we pick some nicer numbers, or comment the choice of numbers / their relations? I have no idea what the % ratio between these numbers is by just looking at it
There was a problem hiding this comment.
Ok, it's nicer now as logic is simplified
sunnya97
reviewed
May 12, 2021
sunnya97
reviewed
May 12, 2021
sunnya97
reviewed
May 12, 2021
antstalepresh
changed the title
antstalepresh
deleted the
possible_modifications_for_mint_amount_distribution
branch
sunnya97
added a commit
that referenced
this pull request
May 17, 2021
* merge pool incentives proposals into one * portion of distribution into community pool * pool incentives own beginblocker to hooks * fix gamm tests for gas overflow * add distribution test for community pool of portion * add test for community pool increase when records are not set * move allocation ratio from pool incentives to mint * fix test anyway * add logger for empty distribution event * modifications for mint amount distribution (#170) * possible modifications for mint amount distribution * updates so far * updates so far * fix tests for distribution * changes for BeginBlocker function call on mint distribution finish * Apply suggestions from code review Co-authored-by: Sunny Aggarwal <sunny@sikka.tech>
sunnya97
added a commit
that referenced
this pull request
May 17, 2021
* Add `pool-incentives` module * Update `app.go` * Add the gov clients for the `pool-incentives` module * Fix `CreatePoolPots` to create pots based on the denom of the pool’s share * Add some tests * Fix the missed initializer for the `EditPoolIncentivesProposal` * Change the distr record to be able to be registered only * Add initial docs * Update x/pool-incentives/types/key.go Co-authored-by: Sunny Aggarwal <sunny@sikka.tech> * Update x/pool-incentives/spec/02_state.md Co-authored-by: Sunny Aggarwal <sunny@sikka.tech> * Merge pool incentives proposals into one (#161) * merge pool incentives proposals into one * Update x/pool-incentives/client/cli/tx.go Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * small fixes for comments and error handling for pool-incentives (#168) * Portion of distribution into community pool (#166) * merge pool incentives proposals into one * portion of distribution into community pool * fix gamm tests for gas overflow * add distribution test for community pool of portion * add test for community pool increase when records are not set Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * Update x/pool-incentives/spec/01_concepts.md Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * Update x/pool-incentives/keeper/distr_test.go Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * Update x/pool-incentives/keeper/distr_test.go Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * Update x/pool-incentives/keeper/distr_test.go Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * Update x/pool-incentives/keeper/distr_test.go Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> * switch pool_incentives to use hooks instead of begin_blocker (#167) * merge pool incentives proposals into one * portion of distribution into community pool * pool incentives own beginblocker to hooks * fix gamm tests for gas overflow * add distribution test for community pool of portion * add test for community pool increase when records are not set * move allocation ratio from pool incentives to mint * fix test anyway * add logger for empty distribution event * modifications for mint amount distribution (#170) * possible modifications for mint amount distribution * updates so far * updates so far * fix tests for distribution * changes for BeginBlocker function call on mint distribution finish * Apply suggestions from code review Co-authored-by: Sunny Aggarwal <sunny@sikka.tech> * add right denom in preparegenesis * should error if try to distribute to a pot that doesn't exist * address @ValarDragon's comment Co-authored-by: Sunny Aggarwal <sunny@sikka.tech> Co-authored-by: antstalepresh <36045227+antstalepresh@users.noreply.github.com> Co-authored-by: Dev Ojha <ValarDragon@users.noreply.github.com> Co-authored-by: Sunny Aggarwal <sunnya97@protonmail.ch>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.