fix(stableswap): Return correct number of shares when joining stableswap pool #1723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `joinPoolSharesInternal` method was not taking into account the newShares from single-sided LP joins.
github-actions
bot
added
the
C:x/gamm
p0mvn
approved these changes
Jun 9, 2022
|
We should unit test |
mergify bot
pushed a commit
that referenced
this pull request
Jun 9, 2022
…wap pool (#1723) * Return correct number of shares when joining stableswap pool The `joinPoolSharesInternal` method was not taking into account the newShares from single-sided LP joins. * Update changelog Co-authored-by: Roman <roman@osmosis.team> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 2d1804b)
mattverse
pushed a commit
that referenced
this pull request
Jun 9, 2022
…wap pool (#1723) (#1728) * Return correct number of shares when joining stableswap pool The `joinPoolSharesInternal` method was not taking into account the newShares from single-sided LP joins. * Update changelog Co-authored-by: Roman <roman@osmosis.team> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> (cherry picked from commit 2d1804b) Co-authored-by: Kevin Yang <5478483+k-yang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #XXX
What is the purpose of the change
The
joinPoolSharesInternalmethod was not taking into account the newShares from single-sided LP joins. I wanted to make sure another Osmosis bug didn't happen related to LP share calculation.Brief Changelog
Testing and Verifying
(Please pick one of the following options)
This change fixes code that doesn't have test coverage yet.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? (yes / no)