Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ICAHost to AppModuleBasics #1825

Merged
merged 2 commits into from
Jun 20, 2022
Merged

Add ICAHost to AppModuleBasics #1825

merged 2 commits into from
Jun 20, 2022

Conversation

ValarDragon
Copy link
Member

Closes: #1710, Supercedes #1711

What is the purpose of the change

Adds ICAHost to AppModuleBasic, fixes test by having it skip the problematic line in tests.

Brief Changelog

  • Adds ICAHost to AppModuelBasics

Testing and Verifying

I have not verified the change. This is by module writing standards more correct (though I didn't see this in the IBC upgrade docs)

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? yes
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? Not documented

@ValarDragon ValarDragon requested a review from a team June 20, 2022 03:45
@github-actions github-actions bot added the C:app-wiring Changes to the app folder label Jun 20, 2022
@ValarDragon ValarDragon mentioned this pull request Jun 20, 2022
Closed
mattverse
mattverse approved these changes Jun 20, 2022
View reviewed changes
Copy link
Member

@mattverse mattverse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah this is so much better than commenting test out for v10 >=. Nice fix! LGTM!

@ValarDragon ValarDragon merged commit d4913ba into main Jun 20, 2022
@ValarDragon ValarDragon deleted the dev/add_icahost_to_initgenesis branch June 20, 2022 19:47
@georgelombardi97 georgelombardi97 mentioned this pull request Sep 8, 2022
Closed
@github-actions github-actions bot mentioned this pull request May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattverse mattverse mattverse approved these changes

Assignees
No one assigned
Labels
C:app-wiring Changes to the app folder
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Interchain Accounts module registration
2 participants
@ValarDragon @mattverse