Move random genesis to an extension interface #2081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
C:app-wiring
Closed
4 tasks
czarcas7ic
approved these changes
Jul 15, 2022
| Actions() []Action | ||
| // PropertyTests() | ||
| } | ||
|
|
||
| type AppModuleSimulationV2WithRandGenesis interface { | ||
| AppModuleSimulationV2 | ||
| // TODO: Come back and improve SimulationState interface |
There was a problem hiding this comment.
Can you describe the desired endstate for what an improved SimulationState interface would look like?
There was a problem hiding this comment.
I don't have a clear end state in mind yet, just its blatant that whats in the legacy thing is very bad / needs to be rethought
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
## What is the purpose of the change
Remove random genesis state from module API, and demo this change for other people doing something on the SDK
Brief Changelog
(We still need to come back and unscrew up all the genesis handling, but this is a nice step in the direction)
Testing and Verifying
FullAppSimulation still making lockup module messages succesfully. Checked via local execution.
Documentation and Release Note
Unreleasedsection inCHANGELOG.md? no